Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Explicit configuration API properties. #841

Open
wants to merge 1 commit into
base: 7
Choose a base branch
from

Conversation

mfendeksilverstripe
Copy link
Contributor

ENH: Explicit configuration API properties.

Description

  • Added explicit configuration API properties for existing settings
  • Minor code refactor for tests (DRY code cleanup)
  • No functional changes overall

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Sorry, something went wrong.

@mfendeksilverstripe
Copy link
Contributor Author

Hey @GuySartorelli , need some guidance with this one as this is technically just a code refactor with no functional changes. I did add new configuration API properties but these are for existing settings.

@GuySartorelli
Copy link
Contributor

Yup no problem. What guidance are you after specifically?

@mfendeksilverstripe mfendeksilverstripe force-pushed the bugfix/configuration-api branch from 0352fe6 to 973526e Compare April 8, 2024 19:11
@mfendeksilverstripe
Copy link
Contributor Author

This is a non-functional code refactor change-set. Which base branch should be used @GuySartorelli ?

@GuySartorelli
Copy link
Contributor

GuySartorelli commented Apr 8, 2024

Refactors which don't have API breaking changes should target the next minor release (so 7 in this case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants